Make "trace" method protected in RESTDataSource #4816
Closed
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be helpful if `trace` method is protected instead of private. This would allow to add some custom reporting of time taken to do the request instead of just console.log. Without marking the method as protected you either need to ts-ignore the override or you need to override get/post/patch/delete/put, or have a complete custom implementation.
|
@tsareg: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
tsareg
changed the title
|
This package has moved to a new repository. I'm closing this PR, but we do plan to spend some time working on RESTDataSource soon; I opened apollographql/datasource-rest#21 to remind us to look at this PR. Sorry for the delay! |
|
(we did this a while ago in #3940) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be helpful if
tracemethod is protected instead of private. This would allow to add some custom reporting of time taken to do the request instead of just console.log. Without marking the method as protected you either need to ts-ignore the override or you need to override get/post/patch/delete/put, or have a complete custom implementation.